Skip to content

Support for rescript 9.1.1 with changed location of binaries #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

smh
Copy link
Contributor

@smh smh commented Apr 18, 2021

Upgraded to rescript-vscode 1.0.8
Handle changed location of bsc binaries

@ryyppy
Copy link
Member

ryyppy commented Apr 20, 2021

Awesome! Gonna review this later today.

@ryyppy
Copy link
Member

ryyppy commented Apr 26, 2021

Quick update:
The latest updates for the new rescript package / code analysis binary are more thorough than anticipated. I will create a new PR with your commits as a baseline and add all the behavior that's missing + the new, slimmed down version of the server tools.

@ryyppy
Copy link
Member

ryyppy commented May 6, 2021

gonna close this one, since I cherrypicked some of your commits for the newest release!

@ryyppy ryyppy closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants